Fix failing test in worker spec #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is currently processing.
nettofarah
approved these changes
Apr 13, 2017
nettofarah
left a comment
nettofarah
left a comment
There was a problem hiding this comment.
LGTM.
It might be worth adding a comment to that test and explaining the possible race condition we were running into before these changes
lib/segment/analytics/worker.rb
Outdated
| # | ||
| def is_requesting? | ||
| @lock.synchronize { !@batch.empty? } | ||
| @lock.synchronize { @batch.present? } |
There was a problem hiding this comment.
this relies on activesupport, which is a dependency you usually don't want to have in more generic gems.
We might wanna change this to use any?
Contributor
Author
There was a problem hiding this comment.
I used it as we already have it in our gemspec.
| end | ||
| end | ||
|
|
||
| res = Request.new.post @write_key, @batch |
| end | ||
|
|
||
| it 'returns true if there is a current batch' do | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
is_requesting?method of workerreturns true if there is a current batch@benjaminhoffman
Note : Intention of this PR is to re run test in travis